Attention is currently required from: pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 ) Change subject: gsm/ipa: Add segmentation callback ...................................................................... Patch Set 4: (4 comments) File include/osmocom/gsm/ipa.h: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/539c9206_4a3fa969 PS2, Line 74: int ipa_iofd_segmentation_cb(struct msgb *msg, int read);
what does "read" mean here? read_bytes? read_rc? ah I had deleted this line, but that must have gotten lost somehow in a local change after I changed my workflow
File src/gsm/ipa.c: https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/995caa9c_cdd4d12a PS2, Line 724: if (msgb_length(msg) < sizeof(struct ipaccess_head))
cosmetic: more than one line, add curly braces please Done
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/dfdfae1a_12d9218a PS2, Line 727: struct ipaccess_head *hh
const? Done
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/10d48632_720d9922 PS2, Line 730: payload_len < 0
I doubt this is possible, because a) `size_t` unsigned, and b) neither `hh->len` nor `sizeof(*hh)` c […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Gerrit-Change-Number: 33083 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 06 Jun 2023 14:53:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment