Attention is currently required from: pespin, fixeria.

View Change

4 comments:

• File include/osmocom/gsm/ipa.h:

  • Patch Set #2, Line 74: int ipa_iofd_segmentation_cb(struct msgb *msg, int read);

    what does "read" mean here? read_bytes? read_rc?

    ah I had deleted this line, but that must have gotten lost somehow in a local change after I changed my workflow

• File src/gsm/ipa.c:

  • Patch Set #2, Line 724: if (msgb_length(msg) < sizeof(struct ipaccess_head))

    cosmetic: more than one line, add curly braces please

    Done

  • Patch Set #2, Line 727: struct ipaccess_head *hh

    const?

    Done

  • Patch Set #2, Line 730: payload_len < 0

    I doubt this is possible, because a) `size_t` unsigned, and b) neither `hh->len` nor `sizeof(*hh)` c […]

    Done

To view, visit change 33083. To unsubscribe, or for help writing mail filters, visit settings.