Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27016 )

Change subject: Allow configuration of interfaces/lines via VTY ......................................................................

Patch Set 5: Code-Review+2

(6 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/2664896b_f0f5a20e PS3, Line 15: those E1 lines with VTY configuration opened.

are opened / will be opened.

no, I'm using past tense here. "so far, osmo-e1d automatically opened..." but now it is changing. I could als have written "used to open".

File src/e1d.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/f2f15123_3918d340 PS3, Line 181: e1d_find_intf_by_serial(struct e1_daemon *e1d, const char *serial_str);

by_usb_serial?

Ack

File src/usb.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/acb8c8ba_4226b626 PS3, Line 561: /* try to find the matching interface config in the */

in the what?

Ack

https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/775c58d6_6a866782 PS3, Line 564: LOGP(DE1D, LOGL_INFO, "configuration for icE1usb serial '%s' found\n", serial_str);

start with caps

Ack

https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/e86a9e3b_54ee9f7c PS3, Line 567: LOGP(DE1D, LOGL_ERROR, "new device with serial '%s', but E1 interface %u busy\n",

start with caps

Ack

https://gerrit.osmocom.org/c/osmo-e1d/+/27016/comment/e75ec9c0_6228a234 PS3, Line 576: LOGP(DE1D, LOGL_NOTICE, "no configuration for icE1usb serial '%s' found, "

start with caps

Ack