Attention is currently required from: pespin.

Patch set 5:Code-Review +2

View Change

6 comments:

• Commit Message:

  • Patch Set #3, Line 15: those E1 lines with VTY configuration opened.

    are opened / will be opened.

    no, I'm using past tense here. "so far, osmo-e1d automatically opened..." but now it is changing. I could als have written "used to open".

• File src/e1d.h:

  • Patch Set #3, Line 181: e1d_find_intf_by_serial(struct e1_daemon *e1d, const char *serial_str);

    by_usb_serial?

    Ack

• File src/usb.c:

  • Patch Set #3, Line 561: /* try to find the matching interface config in the */

    in the what?

    Ack

  • Patch Set #3, Line 564: LOGP(DE1D, LOGL_INFO, "configuration for icE1usb serial '%s' found\n", serial_str);

    start with caps

    Ack

  • Patch Set #3, Line 567: LOGP(DE1D, LOGL_ERROR, "new device with serial '%s', but E1 interface %u busy\n",

    start with caps

    Ack

  • Patch Set #3, Line 576: LOGP(DE1D, LOGL_NOTICE, "no configuration for icE1usb serial '%s' found, "

    start with caps

    Ack

To view, visit change 27016. To unsubscribe, or for help writing mail filters, visit settings.