Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/27015 )
Change subject: e1_{intf,line}_new: Allow caller to specify the numeric identifier
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/intf_line.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/27015/comment/a5a508b7_87c86837
PS1, Line 119: return NULL;
probably some error message here would be informative.
Ack
https://gerrit.osmocom.org/c/osmo-e1d/+/27015/comment/8597401e_077f46b5
PS1, Line 202: return NULL;
same
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/27015
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I9ff80831a3e3e3cb6dae178f8b438a9f3f4747df
Gerrit-Change-Number: 27015
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jan 2022 18:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment