Attention is currently required from: fixeria, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI ......................................................................

Patch Set 7:

(3 comments)

Patchset:

PS7: In general: I'm really unhappy about the code review of this change. The initial commit was a simple understandable 3-line-diff. So much time and effort went into this code.

It would be great if the osmocom code which is tested by this would be in a much greater state and getting better code review instead of putting so much time into testing code.

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/cfbf39b0_75e78... : PS7, Line 254: boolean allow_imsi := true, boolean allow_imei := true

unused args

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/8314434c_da0e2... : PS7, Line 269: var MobileIdentityLV mi;

unused var

Done