Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #7:

    In general: I'm really unhappy about the code review of this change. The initial commit was a simple understandable 3-line-diff.
    So much time and effort went into this code.

    It would be great if the osmocom code which is tested by this would be in a much greater state and getting better code review instead of putting so much time into testing code.

• File sgsn/BSSGP_ConnHdlr.ttcn:

  • Patch Set #7, Line 254: boolean allow_imsi := true, boolean allow_imei := true

    unused args

    Done

  • Patch Set #7, Line 269: var MobileIdentityLV mi;

    unused var

    Done

To view, visit change 38398. To unsubscribe, or for help writing mail filters, visit settings.