[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif - gerrit-log

1 Sep 2025

Attention is currently required from: pespin.

falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email )

Change subject: bring twrtp into libosmo-netif
......................................................................

Patch Set 7:

(3 comments)

File include/osmocom/netif/twrtp.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/72729e24_3f110f2… :
PS1, Line 26: struct osmo_twrtp_stats {
...
  Similarly to the public struct discussion I opened in
the previous twjit patch, it also applies here […] Please see how I handle it in
Patchset 7.

File src/twrtp.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/1f48a891_01871ca… :
PS6, Line 231: 	endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL,
...
  Did you think about deferring this allocation step
until osmo_twrtp_supply_fds is called? at least f […] Please see how I handle it in
Patchset 7.

File src/twrtp_base.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/10e8de60_f9a29ba… :
PS1, Line 132:  * another variant of this API with that alternative behavior.
...
  I'd prefer deferr/avoid allocating rtcp iofd if
not needed. Please see how I handle it in Patchset 7.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb
Gerrit-Change-Number: 39281
Gerrit-PatchSet: 7
Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Sun, 31 Aug 2025 23:38:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;