Attention is currently required from: pespin.

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email )

Change subject: bring twrtp into libosmo-netif ......................................................................

Patch Set 7:

(3 comments)

File include/osmocom/netif/twrtp.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/72729e24_3f110f23... : PS1, Line 26: struct osmo_twrtp_stats {

Similarly to the public struct discussion I opened in the previous twjit patch, it also applies here […]

Please see how I handle it in Patchset 7.

File src/twrtp.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/1f48a891_01871ca3... : PS6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL,

Did you think about deferring this allocation step until osmo_twrtp_supply_fds is called? at least f […]

Please see how I handle it in Patchset 7.

File src/twrtp_base.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/10e8de60_f9a29bac... : PS1, Line 132: * another variant of this API with that alternative behavior.

I'd prefer deferr/avoid allocating rtcp iofd if not needed.

Please see how I handle it in Patchset 7.