Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/netif/twrtp.h:

  • Patch Set #1, Line 26: struct osmo_twrtp_stats {

    Similarly to the public struct discussion I opened in the previous twjit patch, it also applies here […]

    Please see how I handle it in Patchset 7.

• File src/twrtp.c:

  • Patch Set #6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL,

    Did you think about deferring this allocation step until osmo_twrtp_supply_fds is called? at least f […]

    Please see how I handle it in Patchset 7.

• File src/twrtp_base.c:

  • Patch Set #1, Line 132: * another variant of this API with that alternative behavior.

    I'd prefer deferr/avoid allocating rtcp iofd if not needed.

    Please see how I handle it in Patchset 7.

To view, visit change 39281. To unsubscribe, or for help writing mail filters, visit settings.