Attention is currently required from: pespin, fixeria.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32566 )
Change subject: tlv: Show bug in decoded tlv_parsed for type TLV_TYPE_SINGLE_TV ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: See my comment about the comment, but feel free to merge as-is.
File tests/tlv/tlv_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/32566/comment/fa25866c_eaee4048 PS1, Line 473: //FIXME! I find the fixme here (and below) confusing, better would be a comment explaining that this tests for the current behaviour and will be changed once the parser is fixed.
I general I dislike our rule that "tests must always pass", but that is a different discussion.