Attention is currently required from: fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32566 ) Change subject: tlv: Show bug in decoded tlv_parsed for type TLV_TYPE_SINGLE_TV ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File tests/tlv/tlv_test.c: https://gerrit.osmocom.org/c/libosmocore/+/32566/comment/db8e3b48_02e991f0 PS1, Line 473: //FIXME!

I find the fixme here (and below) confusing, better would be a comment explaining that this tests fo […] I think it's fine not spending time here since it will be merged together with the follow up commit. I think having it split into 2 tests has other benefits than "test must always pass". For instance somebody can easily switch versions and test whatever behavior before and after the patch.

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia17c84059a413f80c2bcf194034ebac586ecf7e1 Gerrit-Change-Number: 32566 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Tue, 02 May 2023 11:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment