Attention is currently required from: fixeria, daniel.

Patch set 1:Code-Review +2

View Change

1 comment:

• File tests/tlv/tlv_test.c:

  • Patch Set #1, Line 473: //FIXME!

    I find the fixme here (and below) confusing, better would be a comment explaining that this tests fo […]

    I think it's fine not spending time here since it will be merged together with the follow up commit.
    I think having it split into 2 tests has other benefits than "test must always pass". For instance somebody can easily switch versions and test whatever behavior before and after the patch.

To view, visit change 32566. To unsubscribe, or for help writing mail filters, visit settings.