Attention is currently required from: pespin, fixeria.
Patch set 1:Code-Review +1
2 comments:
Patchset:
See my comment about the comment, but feel free to merge as-is.
File tests/tlv/tlv_test.c:
Patch Set #1, Line 473: //FIXME!
I find the fixme here (and below) confusing, better would be a comment explaining that this tests for the current behaviour and will be changed once the parser is fixed.
I general I dislike our rule that "tests must always pass", but that is a different discussion.
To view, visit change 32566. To unsubscribe, or for help writing mail filters, visit settings.