Attention is currently required from: daniel, fixeria, laforge.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email )

Change subject: card_key_provider: add PostgreSQL support ......................................................................

Patch Set 8:

(3 comments)

File contrib/csv-to-pgsql.py:

https://gerrit.osmocom.org/c/pysim/+/41508/comment/5aab183d_35a2f0b1?usp=ema... : PS5, Line 38: table_name

Consistency with what? Now that you have `.lower()` here, I see no point doing this below.

Done

File contrib/csv-to-pgsql.py:

https://gerrit.osmocom.org/c/pysim/+/41508/comment/59f3f933_945e2466?usp=ema... : PS7, Line 80: self.table

Shouldn't this be `table_names`?

This detects the type of the table. If the table is called something like "my_euicc_keys_for_something" the program knows that it has to create a table for eUICC cards. When the table is called something like "all_my_uicc_keys", then it knows that it has to create a table for UICC cards.

https://gerrit.osmocom.org/c/pysim/+/41508/comment/ae58843e_c8526744?usp=ema... : PS7, Line 117: str(self.table.lower()))

Done