Attention is currently required from: daniel, fixeria, laforge.

View Change

3 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #5, Line 38: table_name

    Consistency with what? Now that you have `.lower()` here, I see no point doing this below.

    Done

• File contrib/csv-to-pgsql.py:

  • Patch Set #7, Line 80: self.table

    Shouldn't this be `table_names`?

    This detects the type of the table. If the table is called something like "my_euicc_keys_for_something" the program knows that it has to create a table for eUICC cards. When the table is called something like "all_my_uicc_keys", then it knows that it has to create a table for UICC cards.

  • Patch Set #7, Line 117: str(self.table.lower()))

    ```suggestion […]

    Done

To view, visit change 41508. To unsubscribe, or for help writing mail filters, visit settings.