Attention is currently required from: pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email )

Change subject: mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in ......................................................................

Patch Set 1: Code-Review+1

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/ed499b16_29e4fe50 PS1, Line 8: could you include some before and after log output?

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/3265754a_9577d428 PS1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf)); +1 for slashing LOGPC 👍

(we could use osmo_sockaddr_to_str_c(OTC_SELECT,..) or _buf(..) with static buffer for the second addr)

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/5115db42_559c8b3d PS1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa), doesn't osmo_sockaddr_to_str() already include the port?

(completely different question, should we even care where RTP is coming from)