Attention is currently required from: dexter, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email ) Change subject: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0 ...................................................................... Patch Set 3: Code-Review-1 (8 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/8b8940cf_ddbe4eb8 PS3, Line 7: cli (i'd prefer unabbreviated "client", vs. "cmdline interface") Patchset: PS3: marking -1 to clarify conflict with https://gerrit.osmocom.org/c/osmo-mgw/+/34899 File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/1a8a1131_f8a0af89 PS3, Line 1317: ip missing msgb_free()? also like below, maybe just omit addr instead https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/56e842d6_7a4a48db PS3, Line 1323: urn - maybe we should just omit the address, same as unset flag _PRESENCE_AUDIO_IP? https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/db76e38c_fb086adb PS3, Line 1339: et same as above, maybe just skip this when port == 0 https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/32bbb2d4_f01cb972 PS3, Line 1353: codecs this conflicts with branch neels/fmtp see https://gerrit.osmocom.org/c/osmo-mgw/+/34899 so after that patch we only use ptmap[], not codecs[]. In that patch, it's not yet clear how to re-add backwards compat; the patch removes codecs[], but instead codecs[] has to stay for compat, even though only ptmap[] is in use; maybe we can dynamically adopt codecs[] into ptmap[] ... so how do we resolve this conflict, rebase this onto neels/fmtp or vice versa? which patch has higher priority for users? either way, ultimately this code should s/codecs[i]/ptmap[i].codec/ https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/918b6913_2280908e PS3, Line 1367: * indent https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/62c28d66_3cc658f7 PS3, Line 1373: * . -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I30165dbac5e484011d0acf46af36f105954a501d Gerrit-Change-Number: 35152 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 00:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment