Attention is currently required from: dexter, pespin.
Patch set 3:Code-Review -1
8 comments:
Commit Message:
(i'd prefer unabbreviated "client", vs. "cmdline interface")
Patchset:
marking -1 to clarify conflict with https://gerrit.osmocom.org/c/osmo-mgw/+/34899
File src/libosmo-mgcp-client/mgcp_client.c:
missing msgb_free()?
also like below, maybe just omit addr instead
Patch Set #3, Line 1323: urn -
maybe we should just omit the address, same as unset flag _PRESENCE_AUDIO_IP?
same as above, maybe just skip this when port == 0
Patch Set #3, Line 1353: codecs
this conflicts with branch neels/fmtp
see https://gerrit.osmocom.org/c/osmo-mgw/+/34899
so after that patch we only use ptmap[], not codecs[].
In that patch, it's not yet clear how to re-add backwards compat; the patch removes codecs[], but instead codecs[] has to stay for compat, even though only ptmap[] is in use; maybe we can dynamically adopt codecs[] into ptmap[] ...
so how do we resolve this conflict, rebase this onto neels/fmtp or vice versa?
which patch has higher priority for users?
either way, ultimately this code should s/codecs[i]/ptmap[i].codec/
indent
.
To view, visit change 35152. To unsubscribe, or for help writing mail filters, visit settings.