Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 8:

    could you include some before and after log output?

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));

    +1 for slashing LOGPC 👍

    (we could use osmo_sockaddr_to_str_c(OTC_SELECT,..) or _buf(..) with static buffer for the second addr)

  • Patch Set #1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa),

    doesn't osmo_sockaddr_to_str() already include the port?

    (completely different question, should we even care where RTP is coming from)

To view, visit change 35175. To unsubscribe, or for help writing mail filters, visit settings.