Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 )
Change subject: Add initial CSD support with external MNCC ......................................................................
Patch Set 1:
(3 comments)
File include/osmocom/msc/transaction.h:
https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/b1d2276a_e4f1698d PS1, Line 113: struct csd_filter csd;
union between codecs and csd makes sense?
This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc:
``` sdp_audio_codecs_set_csd(&trans->cc.codecs.ms); ```
File src/libmsc/csd_filter.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/9a50ae9d_f9afcf2c PS1, Line 53: csd_bs_list_add_bs(list, bs_geran[i]);
I see no benefit and several drawbacks in they way you are doing this, instead of calling the functi […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/650505b8_4645893e PS1, Line 70: csd_bs_list_add_bs(list, bs_utran[i]);
same
Done
-
osmith