Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/msc/transaction.h:

  • Patch Set #1, Line 113: struct csd_filter csd;

    union between codecs and csd makes sense?

    This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc:

    ```
    sdp_audio_codecs_set_csd(&trans->cc.codecs.ms);
    ```

• File src/libmsc/csd_filter.c:

  • Patch Set #1, Line 53: csd_bs_list_add_bs(list, bs_geran[i]);

    I see no benefit and several drawbacks in they way you are doing this, instead of calling the functi […]

    Done

  • Patch Set #1, Line 70: csd_bs_list_add_bs(list, bs_utran[i]);

    same

    Done

To view, visit change 33369. To unsubscribe, or for help writing mail filters, visit settings.