Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33369 ) Change subject: Add initial CSD support with external MNCC ...................................................................... Patch Set 1: (3 comments) File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/b1d2276a_e4f1698d PS1, Line 113: struct csd_filter csd;
union between codecs and csd makes sense? This does not work, because for CSD codecs.ms gets set to CSD in trans_cc_filter_set_ms_from_bc:
``` sdp_audio_codecs_set_csd(&trans->cc.codecs.ms); ``` File src/libmsc/csd_filter.c: https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/9a50ae9d_f9afcf2c PS1, Line 53: csd_bs_list_add_bs(list, bs_geran[i]);
I see no benefit and several drawbacks in they way you are doing this, instead of calling the functi […] Done
https://gerrit.osmocom.org/c/osmo-msc/+/33369/comment/650505b8_4645893e PS1, Line 70: csd_bs_list_add_bs(list, bs_utran[i]);
same Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ide8b8321e0401dcbe35da2ec9cee0abca821d99a Gerrit-Change-Number: 33369 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 11:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment