Attention is currently required from: laforge.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 )

Change subject: ASCI: Add processing and FSMs for VGCS/VBS ......................................................................

Patch Set 6:

(4 comments)

File src/osmo-bsc/vgcs_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/8eed4dc6_fcea32c1 PS4, Line 72: sprintf(string, "%08u", callref);

as I wrote elsewhere, I think it's good practice to use snprintf, even if (after review) we can assu […]

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/36c65553_2305558f PS4, Line 451: vgcs_call_fsm

I believe we had the discussion already at some other location: Please don't use the _fsm suffix in […]

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/5e39816a_ead0dce5 PS4, Line 1044: vgcs_chan_fsm

no _fsm suffix, please

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/06ece290_7ea70f7a PS4, Line 1093: LOGP(DASCI, LOGL_ERROR, "Unable to decode Channel Type.\n");

there are a lot of "raw" LOGP statements here, not providing any context. […]

Done