Attention is currently required from: laforge.

View Change

4 comments:

• File src/osmo-bsc/vgcs_fsm.c:

  • Patch Set #4, Line 72: sprintf(string, "%08u", callref);

    as I wrote elsewhere, I think it's good practice to use snprintf, even if (after review) we can assu […]

    Done

  • Patch Set #4, Line 451: vgcs_call_fsm

    I believe we had the discussion already at some other location: Please don't use the _fsm suffix in […]

    Done

  • Patch Set #4, Line 1044: vgcs_chan_fsm

    no _fsm suffix, please

    Done

  • Patch Set #4, Line 1093: LOGP(DASCI, LOGL_ERROR, "Unable to decode Channel Type.\n");

    there are a lot of "raw" LOGP statements here, not providing any context. […]

    Done

To view, visit change 33611. To unsubscribe, or for help writing mail filters, visit settings.