Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33610 ) Change subject: ASCI: Add encoding of VGCS/VBS A-interface messages ...................................................................... Patch Set 5: (1 comment) File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33610/comment/9db30e80_4e563530 PS3, Line 1749: void tx_setup_ack(struct gsm_subscriber_connection *conn, struct gsm0808_vgcs_feature_flags *ff)

all the other functions appear to be called bsc_tx_* […] Right. Strange that i did not see that.

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic2203a5119a226ac859a91dc42d81cbd71027ec8 Gerrit-Change-Number: 33610 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Thu, 13 Jul 2023 10:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment