Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837 )

Change subject: tests/ranap_rab_ass: fix NULL pointer dereference ......................................................................

Patch Set 1:

(2 comments)

File tests/ranap_rab_ass/ranap_rab_ass_test.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/7e5e73df_54091c49 PS1, Line 64: encoded ? "ok" : "ERROR" This makes Coverity think that encoded can be NULL. And yes, in src/osmo-hnbgw/ranap_rab_ass.c I see that it can actually return NULL.

https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/01cb5e4a_e7e88095 PS1, Line 67: if (encoded != NULL) {

I'm a bit lost here. […]

See my comment above. I don't like the idea of adding OSMO_ASSERT() because it makes harder to add new tests showing some bug. Fine with adding "potential".