Attention is currently required from: pespin.

View Change

2 comments:

• File tests/ranap_rab_ass/ranap_rab_ass_test.c:

  • Patch Set #1, Line 64: encoded ? "ok" : "ERROR"

    This makes Coverity think that encoded can be NULL. And yes, in src/osmo-hnbgw/ranap_rab_ass.c I see that it can actually return NULL.

  • Patch Set #1, Line 67: if (encoded != NULL) {

    I'm a bit lost here. […]

    See my comment above. I don't like the idea of adding OSMO_ASSERT() because it makes harder to add new tests showing some bug. Fine with adding "potential".

To view, visit change 28837. To unsubscribe, or for help writing mail filters, visit settings.