Attention is currently required from: neels, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28822
)
Change subject: sbcap: Request and handle Write Replace Warning Indication
......................................................................
Patch Set 3:
(1 comment)
File src/sbcap_msg.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/8e20f213_a61f126e
PS3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24,
SBcAP_Criticality_ignore,
the comment above should make it clear. […]
Because asn1c is not exporting those values in a header file, as you can see in the
commit they are declared static.
I may add our own enum with the IDs later on, and change all of them, not urgent though.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28822
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I563e7d1c999f14b8197bb41e85b7bcf6262fe2a0
Gerrit-Change-Number: 28822
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment