Attention is currently required from: osmith, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28824
)
Change subject: sbcap: Improve handling of WriteReplaceWarnResponse
......................................................................
Patch Set 3:
(2 comments)
File src/sbcap_link_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/c893150f_dc8e3e05
PS3, Line 256: /* static const long asn_VAL_19_SBcAP_id_Cause = 1; */
this appears to be meant to explain the '1' in
the line below. […]
Yes, it's generated as static. As I wrote in the other
patch, I may work on adding our own enum in sbcap_common.h but it's not really
urgent.
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/aff1e326_73993a70
PS3, Line 264: SBcAP_Cause_missing_mandatory_element, pdu);
Looks like error with missing mandatory element is
sent back even if cause is not accepted. […]
Sorry I'm not following you here.
how can you access "cause" before "ie" in your example if
"cause" is found inside "ie"?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28824
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d5bdbb6c4fd3870a4f4ebf226668b70fea06a
Gerrit-Change-Number: 28824
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:38:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment