Attention is currently required from: laforge, lynxis lazus.
dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41579?usp=email )
Change subject: pySim.runtime: Fix file selection by upper case hex FID ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1: As far as I can see this patch looks good. I have left one comment with an idea to make this approach more general.
File pySim/runtime.py:
https://gerrit.osmocom.org/c/pysim/+/41579/comment/255ce142_ced8e17d?usp=ema... : PS1, Line 488: name = name.lower() I think this is ok. I see lines like this in select also. However, it might be worth checking if is possible to generalize this with a method or function that just gets us the file object either by name or by FID. This function would then accept case insensitive FIDs and case sensitive file names.
-
dexter