Attention is currently required from: osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email )
Change subject: update to prepare for IPv6 support ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libgtpnl/+/34734/comment/ad8c7b90_428385e2 PS1, Line 7: update to p Please expand a little bit what the change does. Like "Introduce a union in struct foo ..."
File src/internal.h:
https://gerrit.osmocom.org/c/libgtpnl/+/34734/comment/0ab12524_f31f88b9 PS1, Line 22: } ip;
given that we'll have an ip6 counterpart, naming this one "ip4" may be easier to understand for read […]
I would agree, it should be ip4/ip6, or something else that is clearly understood. "ip" is unspecific and includes any version of IP