Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email ) Change subject: update to prepare for IPv6 support ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libgtpnl/+/34734/comment/ad8c7b90_428385e2 PS1, Line 7: update to p Please expand a little bit what the change does. Like "Introduce a union in struct foo ..." File src/internal.h: https://gerrit.osmocom.org/c/libgtpnl/+/34734/comment/0ab12524_f31f88b9 PS1, Line 22: } ip;
given that we'll have an ip6 counterpart, naming this one "ip4" may be easier to understand for read […] I would agree, it should be ip4/ip6, or something else that is clearly understood. "ip" is unspecific and includes any version of IP
-- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ifc7e3b03a723fb544d1c7b789101102b2c27b60e Gerrit-Change-Number: 34734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment