Attention is currently required from: osmith, pespin.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 7: update to p

    Please expand a little bit what the change does. Like "Introduce a union in struct foo ..."

• File src/internal.h:

  • Patch Set #1, Line 22: } ip;

    given that we'll have an ip6 counterpart, naming this one "ip4" may be easier to understand for read […]

    I would agree, it should be ip4/ip6, or something else that is clearly understood. "ip" is unspecific and includes any version of IP

To view, visit change 34734. To unsubscribe, or for help writing mail filters, visit settings.