Attention is currently required from: arehbein, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: vty: Add check against sensible default value for Ny1 ......................................................................
Patch Set 16:
(5 comments)
Patchset:
PS16: your comments suggest some things to be resolved, but they still are unchanged in the latest patch set?
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/f001c355_c2e09980 PS14, Line 1738: unsigned long T3105 = osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1);
Maybe this rule is implied by "linux kernel style". […]
vars are still not declared at the top
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/ac930644_efb86ea8 PS16, Line 537: } (braces are still here)
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/66b170f2_50c23599 PS16, Line 1725: . (stray dot? "iff" isn't an abbreviation in the usual sense)
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/fd912c7f_0f42dbc8 PS16, Line 95: (void)
Done
the "(void)" is still here
-
neels