Attention is currently required from: arehbein, fixeria, pespin.
5 comments:
Patchset:
your comments suggest some things to be resolved, but they still are unchanged in the latest patch set?
File src/osmo-bsc/bts.c:
Patch Set #14, Line 1738: unsigned long T3105 = osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1);
Maybe this rule is implied by "linux kernel style". […]
vars are still not declared at the top
File src/osmo-bsc/bts.c:
(braces are still here)
(stray dot? "iff" isn't an abbreviation in the usual sense)
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
Patch Set #16, Line 95: (void)
Done
the "(void)" is still here
To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.