Attention is currently required from: arehbein, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Patchset: PS4:

Forgot to say. the title for the commit is too generic, doesn't explain what they do. What about: […] pespin, does this also need a TODO-RELEASE entry?

File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/d47d21c4_6c64511d PS4, Line 45: \ref ('\ref' is to reference files, not functions. we've been using it wrongly for some time. Could drop it while busy editing the line anyway: ... call telnet_init_default() once https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API... ) https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/ba612e85_09edd4dd PS4, Line 96: \deprecated (interesting, i wasn't aware of the \deprecated cmd yet) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 01:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment