Attention is currently required from: arehbein, pespin.

Patch set 4:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #4:

    Forgot to say. the title for the commit is too generic, doesn't explain what they do. What about: […]

    pespin, does this also need a TODO-RELEASE entry?

• File src/vty/telnet_interface.c:

  • Patch Set #4, Line 45: \ref

    ('\ref' is to reference files, not functions. we've been using it wrongly for some time. Could drop it while busy editing the line anyway:

     ... call telnet_init_default() once

    https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Parameters
    )

  • Patch Set #4, Line 96: \deprecated

    (interesting, i wasn't aware of the \deprecated cmd yet)

To view, visit change 30703. To unsubscribe, or for help writing mail filters, visit settings.