[M] Change in libosmocore[master]: codec: add SID classification functions per GSM 06.31 & 06.81 - gerrit-log

16 Apr 2023


      Attention is currently required from: falconia, pespin, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32183 )
Change subject: codec: add SID classification functions per GSM 06.31 & 06.81
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File include/osmocom/codec/codec.h:
https://gerrit.osmocom.org/c/libosmocore/+/32183/comment/69fc7fed_79f88a13 
PS1, Line 85: etsi_sid_class
...
In the new patchset the enum is named osmo_gsm631_sid_class and its items are prefixed with OSMO_GSM […]
given that other functions just above/below use osmo_{fr,efr,amr}, I would suggest to use that rather than osmo_gsm631 (which not even I would know off my head which of the codecs it is).  But I'm happy to submit a follow-up patch to do the rename if you think you're running out of patience now.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32183
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie91a52c6f04689082d8004311517d8ce0c544916
Gerrit-Change-Number: 32183
Gerrit-PatchSet: 3
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: falconia falcon@freecalypso.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sun, 16 Apr 2023 09:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia falcon@freecalypso.org
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment