Attention is currently required from: falconia, pespin, fixeria.

Patch set 3:Code-Review +1

View Change

1 comment:

• File include/osmocom/codec/codec.h:

  • Patch Set #1, Line 85: etsi_sid_class

    In the new patchset the enum is named osmo_gsm631_sid_class and its items are prefixed with OSMO_GSM […]

    given that other functions just above/below use osmo_{fr,efr,amr}, I would suggest to use that rather than osmo_gsm631 (which not even I would know off my head which of the codecs it is). But I'm happy to submit a follow-up patch to do the rename if you think you're running out of patience now.

To view, visit change 32183. To unsubscribe, or for help writing mail filters, visit settings.