Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32184 ) Change subject: codec: add SID preening functions for FR & EFR ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/codec/gsm610.c: https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/6bf8bc31_5aa3980e PS3, Line 428: /* should never be reached */ : return false; I would actually put a default clause and OSMO_ASSERT() in it. Just to make sure we don't ever end up silently ignoring strange values that might be hypothetically returned from osmo_fr_sid_classify() in the future. Or alternatively, if you consider it too drastic, put a log message about it. File src/codec/gsm660.c: https://gerrit.osmocom.org/c/libosmocore/+/32184/comment/51b8ed09_1335678b PS3, Line 391: likewise here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec5c1f2619a82499f61cb3e5a7cd03ff0f020ad8 Gerrit-Change-Number: 32184 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: falconia <falcon@freecalypso.org> Gerrit-Comment-Date: Sun, 16 Apr 2023 09:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment