Attention is currently required from: falconia.

Patch set 3:Code-Review +1

View Change

2 comments:

• File src/codec/gsm610.c:

  • Patch Set #3, Line 428:

    	/* should never be reached */
    	return false;
    

    I would actually put a default clause and OSMO_ASSERT() in it. Just to make sure we don't ever end up silently ignoring strange values that might be hypothetically returned from osmo_fr_sid_classify() in the future. Or alternatively, if you consider it too drastic, put a log message about it.

• File src/codec/gsm660.c:

  • Patch Set #3, Line 391:

    likewise here.

To view, visit change 32184. To unsubscribe, or for help writing mail filters, visit settings.