Attention is currently required from: laforge. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 )

Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ......................................................................

Patch Set 5:

(3 comments)

File src/tetra_upper_mac.h:

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/28754212_63505ba7 PS3, Line 13: in

this probably shows how our practices have evolved during the last decade. […]

Done

File src/tetra_upper_mac.c:

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/61706a60_d619f989 PS3, Line 44: s

OK, then lets keep the global/static variables for now, but add a TODO comment that this actualY sho […]

Done

https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/c42479b4_d6d791c3 PS3, Line 50: fragslots[i].msgb = msgb_alloc(FRAGSLOT_MSGB_SIZE, "fragslot");

...

You're right, I could allocate them on demand, whenever a fragmented resource is encountered on a […]

I think dynamic allocation is a good idea, since besides saving a few kilobytes of ram, it also removes the requirement of invoking an initialisation function in tetra-rx.c. Current patch set allocates a message buffer when required and frees it when either the mac/end is encountered or when it is aged out.