Attention is currently required from: laforge. wbokslag has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 ) Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ...................................................................... Patch Set 5: (3 comments) File src/tetra_upper_mac.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/28754212_63505ba7 PS3, Line 13: in
this probably shows how our practices have evolved during the last decade. […] Done
File src/tetra_upper_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/61706a60_d619f989 PS3, Line 44: s
OK, then lets keep the global/static variables for now, but add a TODO comment that this actualY sho […] Done
https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/c42479b4_d6d791c3 PS3, Line 50: fragslots[i].msgb = msgb_alloc(FRAGSLOT_MSGB_SIZE, "fragslot");
You're right, I could allocate them on demand, whenever a fragmented resource is encountered on a […] I think dynamic allocation is a good idea, since besides saving a few kilobytes of ram, it also removes the requirement of invoking an initialisation function in tetra-rx.c. Current patch set allocates a message buffer when required and frees it when either the mac/end is encountered or when it is aged out.
-- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 Gerrit-Change-Number: 29387 Gerrit-PatchSet: 5 Gerrit-Owner: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Thu, 22 Sep 2022 09:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: wbokslag <w.bokslag@midnightblue.nl> Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment