Attention is currently required from: laforge.

View Change

3 comments:

• File src/tetra_upper_mac.h:

  • Patch Set #3, Line 13: in

    this probably shows how our practices have evolved during the last decade. […]

    Done

• File src/tetra_upper_mac.c:

  • Patch Set #3, Line 44: s

    OK, then lets keep the global/static variables for now, but add a TODO comment that this actualY sho […]

    Done

  • Patch Set #3, Line 50: fragslots[i].msgb = msgb_alloc(FRAGSLOT_MSGB_SIZE, "fragslot");

    > You're right, I could allocate them on demand, whenever a fragmented resource is encountered on a […]

    I think dynamic allocation is a good idea, since besides saving a few kilobytes of ram, it also removes the requirement of invoking an initialisation function in tetra-rx.c. Current patch set allocates a message buffer when required and frees it when either the mac/end is encountered or when it is aged out.

To view, visit change 29387. To unsubscribe, or for help writing mail filters, visit settings.