laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30313 )

Change subject: ttcn3-tcpdump-stop.sh: Don't use lsof ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

Ah this was meant to be a reply to Max's comment, but it seems like replies cannot refer to specific […]

This doesn't change the fact that this patch had exactly *one* positive review ("Revieew +1") at the time you decided to simply set it to +2 and merge it. This is not how the process works. You wait until somebody else has given a single +2, or there are two other people having voted with +1 which you are permitted to add to a +2: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Code-Review...

Particularly for a new developer in the project, it is important to follow the proces.