1 comment:
Patchset:
Ah this was meant to be a reply to Max's comment, but it seems like replies cannot refer to specific […]
This doesn't change the fact that this patch had exactly *one* positive review ("Revieew +1") at the time you decided to simply set it to +2 and merge it. This is not how the process works. You wait until somebody else has given a single +2, or there are two other people having voted with +1 which you are permitted to add to a +2: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Code-Review-CR
Particularly for a new developer in the project, it is important to follow the proces.
To view, visit change 30313. To unsubscribe, or for help writing mail filters, visit settings.