Attention is currently required from: neels, laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 )
Change subject: Add subscr_conn_fsm ......................................................................
Patch Set 7: Code-Review+2
(6 comments)
Patchset:
PS7: re-applying +2 after minor changes
File include/osmocom/bsc_nat/subscr_conn_fsm.h:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/3c1f6b7d_e591ce54 PS6, Line 31:
(doesn't the linter complain about trailing blank lines?)
nope
File src/osmo-bsc-nat/bssap_conn.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/50f57106_08e5de5d PS4, Line 47: uint8_t tag = tag_order[i];
Pau is correct that it would indeed be possible to copy the part leading up to the changed IE and th […]
Done
File src/osmo-bsc-nat/bssap_conn.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/4b9e740f_bbe3a730 PS6, Line 49: goto error; bug: rc would be uninitialized here, fixed in patchset 7
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/576c8e95_4ac7c524 PS6, Line 228:
(1 blank line)
Done
File src/osmo-bsc-nat/subscr_conn_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/ebfed292_af5fcd6d PS6, Line 262: osmo_fsm_inst_state_chg(fi, SUBSCR_CONN_FSM_ST_PROCESSING_ASSIGNMENT_COMPLETE_MDCX_RAN, TIMEOUT_MGW, 0);
Did you think about using osmo_tdef_state_timeout instead of passing timers every time? It's easier […]
Thanks! Done in new patch: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/1
-
osmith