Attention is currently required from: neels, laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 ) Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 7: Code-Review+2 (6 comments) Patchset: PS7: re-applying +2 after minor changes File include/osmocom/bsc_nat/subscr_conn_fsm.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/3c1f6b7d_e591ce54 PS6, Line 31:
(doesn't the linter complain about trailing blank lines?) nope
File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/50f57106_08e5de5d PS4, Line 47: uint8_t tag = tag_order[i];
Pau is correct that it would indeed be possible to copy the part leading up to the changed IE and th […] Done
File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/4b9e740f_bbe3a730 PS6, Line 49: goto error; bug: rc would be uninitialized here, fixed in patchset 7 https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/576c8e95_4ac7c524 PS6, Line 228:
(1 blank line) Done
File src/osmo-bsc-nat/subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/ebfed292_af5fcd6d PS6, Line 262: osmo_fsm_inst_state_chg(fi, SUBSCR_CONN_FSM_ST_PROCESSING_ASSIGNMENT_COMPLETE_MDCX_RAN, TIMEOUT_MGW, 0);
Did you think about using osmo_tdef_state_timeout instead of passing timers every time? It's easier […] Thanks! Done in new patch: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/1
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 09 Jun 2022 09:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment