Attention is currently required from: neels, laforge, pespin, fixeria.
Patch set 7:Code-Review +2
6 comments:
Patchset:
re-applying +2 after minor changes
File include/osmocom/bsc_nat/subscr_conn_fsm.h:
(doesn't the linter complain about trailing blank lines?)
nope
File src/osmo-bsc-nat/bssap_conn.c:
Patch Set #4, Line 47: uint8_t tag = tag_order[i];
Pau is correct that it would indeed be possible to copy the part leading up to the changed IE and th […]
Done
File src/osmo-bsc-nat/bssap_conn.c:
Patch Set #6, Line 49: goto error;
bug: rc would be uninitialized here, fixed in patchset 7
(1 blank line)
Done
File src/osmo-bsc-nat/subscr_conn_fsm.c:
Patch Set #6, Line 262: osmo_fsm_inst_state_chg(fi, SUBSCR_CONN_FSM_ST_PROCESSING_ASSIGNMENT_COMPLETE_MDCX_RAN, TIMEOUT_MGW, 0);
Did you think about using osmo_tdef_state_timeout instead of passing timers every time? It's easier […]
Thanks! Done in new patch: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/28249/1
To view, visit change 27712. To unsubscribe, or for help writing mail filters, visit settings.