gerrit-log

gerrit-log@lists.osmocom.org

90474 discussions

Change in osmo-bsc[master]: om2000: Don't print "should not generate any message" on FAULT_REP
by laforge 04 Jan '22

04 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26713 ) Change subject: om2000: Don't print "should not generate any message" on FAULT_REP ...................................................................... om2000: Don't print "should not generate any message" on FAULT_REP Change-Id: I65184ef5aa90a993491f9393614bb499c6998169 Closes: OS#4643 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index 4523555..fc40cc4 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -2970,7 +2970,8 @@ case OM2K_MSGT_FAULT_REP: display_fault_maps(msg->l2h, msgb_l2len(msg), &o2h->mo); rc = abis_om2k_tx_simple(bts, &o2h->mo, OM2K_MSGT_FAULT_REP_ACK); - break; + /* we receive this from MOs without FSM (https://osmocom.org/issues/4643) */ + goto no_mo; case OM2K_MSGT_NEGOT_REQ: rc = om2k_rx_negot_req(msg); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I65184ef5aa90a993491f9393614bb499c6998169 Gerrit-Change-Number: 26713 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: om2000: Don't print "should not generate any message" on FAULT_REP
by laforge 04 Jan '22

04 Jan '22

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26713 ) Change subject: om2000: Don't print "should not generate any message" on FAULT_REP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I65184ef5aa90a993491f9393614bb499c6998169 Gerrit-Change-Number: 26713 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-iuh[master]: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRe...
by pespin 04 Jan '22

04 Jan '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26724 ) Change subject: ranap_rab_ass: add decoder and rewrite functions for RAB-AssignmentRequest/Response ...................................................................... Patch Set 1: (4 comments) Sounds like we should be creating src/hnbgw/ soon and move all hnbgw files there, since we'll be adding more code there. Even maybe thinking about splitting it to a new repository, specially since we'll now depend on libosmo-mgcp in osmo-hnbgw. https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_r… File include/osmocom/iuh/ranap_rab_ass.h: https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_r… PS1, Line 1: #pragma once This file in hnbgw specific afaict, so it must not go into osmo-iuh (libosmo-ranap/rua/sabp) include directory imho, but rather to include/osmocom/hnbgw/ https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/include/osmocom/iuh/ranap_r… PS1, Line 3: int ranap_rab_ass_req_decode(RANAP_RAB_AssignmentRequestIEs_t * rab_assignment_request_ies, const uint8_t *data, please put the "*" attached to the right. https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c File src/ranap_rab_ass.c: https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c@241 PS1, Line 241: * \ptmap[out] addr buffer to store extraced RTP stream IP address (length at least INET6_ADDRSTRLEN). extracted (same immediately below) https://gerrit.osmocom.org/c/osmo-iuh/+/26724/1/src/ranap_rab_ass.c@242 PS1, Line 242: * \ptmap[out] port pointer to store extraced RTP stream IP port number. worth mentioning whether it's network-byte order or host-byte-ordering. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I58b542bf23ff5e1db2ccf6833fec91d9ba332837 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Jan 2022 13:15:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: om2000: Don't print "should not generate any message" on CAL_TIME_REQ
by laforge 04 Jan '22

04 Jan '22

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26712 ) Change subject: om2000: Don't print "should not generate any message" on CAL_TIME_REQ ...................................................................... om2000: Don't print "should not generate any message" on CAL_TIME_REQ Change-Id: Ic6f576250d56707cf325886d70209a3744163d79 Closes: OS#4670 --- M src/osmo-bsc/abis_om2000.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index 16320fc..4523555 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -2965,7 +2965,8 @@ switch (msg_type) { case OM2K_MSGT_CAL_TIME_REQ: rc = abis_om2k_cal_time_resp(bts); - break; + /* we receive this from MOs without FSM (https://osmocom.org/issues/4670) */ + goto no_mo; case OM2K_MSGT_FAULT_REP: display_fault_maps(msg->l2h, msgb_l2len(msg), &o2h->mo); rc = abis_om2k_tx_simple(bts, &o2h->mo, OM2K_MSGT_FAULT_REP_ACK); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6f576250d56707cf325886d70209a3744163d79 Gerrit-Change-Number: 26712 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Jump to page:

2026

2025

2024

2023

2022

gerrit-log